Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Inflector] Correct the spelling of matracies to matraces #44632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Inflector] Correct the spelling of matracies to matraces #44632

wants to merge 2 commits into from

Conversation

gnito-org
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

@carsonbot carsonbot added this to the 4.4 milestone Dec 14, 2021
@carsonbot carsonbot changed the title Correct the spelling of matracies to matraces [Inflector] Correct the spelling of matracies to matraces Dec 14, 2021
@nicolas-grekas
Copy link
Member

This breaks tests. More lines need to be changed apparently.

@gnito-org
Copy link
Contributor Author

The errors all conform to the following pattern:

3) Symfony\Component\Inflector\Tests\InflectorTest::testPluralize with data set #73 ('matrix', array('matrices', 'matrixes'))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'matrices'
+    0 => 'matricies'
     1 => 'matrixes'
 )

However, the word matricies does not occur anywhere in the branch where I corrected the spelling. So, from where is the test getting it?

@nicolas-grekas
Copy link
Member

You might want to take inspiration from eg #43790 which fixes something similar for another word.

@gnito-org
Copy link
Contributor Author

Unfortunately that does not help. I still do not see from where the test is getting the "matricies" that it's listing in the "Actual" line.

@gnito-org
Copy link
Contributor Author

The more overarching question is, why are the tests also failing on other words (fungus, hero) that have nothing to do with the one word I changed in src/Symfony/Component/Inflector/Tests/InflectorTest.php.

Shouldn't those other words cause failures in all CI tests that do not include my word change?

@gnito-org gnito-org closed this Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.