[HttpKernel] Fix SessionListener without session in request #44618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
approved these changes
Dec 14, 2021
|
Yes! Just tested it! I'm struggling with this since I've updated to 5.4. It's a quite rare situation, but in my case I'm having a very early RedirectResponse which crashes with a |
xabbuh
approved these changes
Dec 16, 2021
chalasr
approved these changes
Dec 22, 2021
|
@shyim could you have a look to the failing test please? |
|
I can look tomorrow into it |
|
@jderusse Rebased more jobs are green. MacOS failure doesn't seems to be from my side |
|
Thank you @shyim. |
This was referenced Dec 29, 2021
Merged
Merged
Merged
|
@solverat , How you solved this login isssue in symfony 5.4 ? im also facing same issue, after giving correct credentials , im not able to login to dashboard or index page |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have in our project a Listener for
kernel.requestwhich sets a Response object if it's aOPTIONScall. AsetResponsein the event does stopping all other listeners also the session listener. As the session listener is not triggered in the kernel.request the followup kernel.response event will let the session listener crash.https://github.com/symfony/symfony/blob/5.3/src/Symfony/Component/HttpKernel/EventListener/AbstractSessionListener.php#L80
This line tries to get the session from the container, if its missing it calls
getSessionthis throws then a error Session is not set.It looks like this issue has been fixed already in Symfony 6. See https://github.com/symfony/symfony/blob/6.1/src/Symfony/Component/HttpKernel/EventListener/AbstractSessionListener.php#L99-L101