Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[PropertyInfo] Fix aliased namespace matching #44430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

Korbeil
Copy link
Contributor

@Korbeil Korbeil commented Dec 2, 2021

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #44417
License MIT
Doc PR N/A

When you have an aliased namespace that you use in your code it was erroring because we didn't stored the first part of the namespace that should be replaced.

@Korbeil Korbeil requested a review from dunglas as a code owner December 2, 2021 20:44
@carsonbot carsonbot added this to the 6.1 milestone Dec 2, 2021
@Korbeil Korbeil force-pushed the fix/property-info-use branch from c7309a6 to 432b1a1 Compare December 2, 2021 20:45
@Korbeil Korbeil changed the base branch from 6.1 to 5.4 December 2, 2021 20:45
@Korbeil Korbeil changed the title Fix aliased namespaces matching [PropertyInfo] Fix aliased namespaces matching Dec 2, 2021
@Korbeil Korbeil changed the title [PropertyInfo] Fix aliased namespaces matching [PropertyInfo] Fix aliased namespace matching Dec 2, 2021
@xabbuh xabbuh modified the milestones: 6.1, 5.4 Dec 3, 2021
@nicolas-grekas
Copy link
Member

Thank you @Korbeil.

@nicolas-grekas nicolas-grekas merged commit 4d9f1aa into symfony:5.4 Dec 14, 2021
This was referenced Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PropertyInfo] Namespace use s
7 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.