[Messenger] #44254 Changing queue name precedence #44291
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
There was a problem hiding this comment.
The DSN takes precedence over the options on purpose.
ie. PROD and PRE_PROD share the same configuration (and same queue_name in the messenger.yaml) but they use 2 differents DSN to define the targeted queue.
If you want to share the same DSN across different configurations, you can either:
- remove the queue name from the ENV variabnle, in that way, the connection will fallback to the option
- make the queue name part the DSN. ie.
dsn : "%env(MESSENGER_TRANSPORT_DSN)%/my_queue"
src/Symfony/Component/Messenger/Bridge/AmazonSqs/Tests/Transport/ConnectionTest.php
Outdated
Show resolved
Hide resolved
|
Thanks for your review @jderusse ! In this case I'll let the reporter here know to just remove the queue name from the DSN and specify it explicitly in the options. And then I just left a test for the default message name == 'messages' as I haven't found such a test in the suite. LMK if it makes sense and thanks again! |
Suggesting to change the precedence of
queue_nameoption toconfig -> DSN -> default ("messages")instead of currentDSN -> config -> default ("messages")