[DomCrawler] Make masterminds/html5 as a required dependency of DomCrawler #44170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
reviewed
Nov 20, 2021
derrabus
reviewed
Nov 20, 2021
|
I'm not sure how HtmlSanitizer vs. DomCrawler correlates 🤔 nevertheless i think this makes the implementation more robust 👍 |
|
@ro0NL they correlate because the current implementation is basically an opt-in based on the mere presence of the parser. Having html-sanitizer as a component requiring the parser would opt-in people unexpectedly. This pr solves this. |
3ef6037 to
4dab9df
Compare
|
Can you target 6.1 now that exists? |
|
@tgalopin Can you rebase this PR on 6.1? Is it ready to be merged then? |
4dab9df to
14aacda
Compare
nicolas-grekas
approved these changes
Apr 12, 2022
|
Thank you @tgalopin. |
|
Looks like this is responsible for the grim regression outlined in #48950. |
kesselb
added a commit
to kesselb/symfony-docs
that referenced
this pull request
Feb 16, 2023
html5-php is mandatory after symfony/symfony#44170
kesselb
added a commit
to kesselb/symfony-docs
that referenced
this pull request
Feb 16, 2023
html5-php is mandatory after symfony/symfony#44170
javiereguiluz
pushed a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Feb 17, 2023
html5-php is mandatory after symfony/symfony#44170
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Feb 17, 2023
…esselb) This PR was merged into the 6.2 branch. Discussion ---------- docs(DomCrawler): remove hint about html5-php library html5-php is mandatory after symfony/symfony#44170 <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- 1be7e33 docs(DomCrawler): remove hint about html5-php library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion on #43341 and how we will add a new HtmlSanitizer component to Symfony (#44144), it makes a lot of sense to require masterminds/html5 by default on the DomCrawler component. This PR does this and removes unnecessary checks for the library presence in the code.