[WebProfilerBundle] Tweak the colors of the security panel #44115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Nov 17, 2021
src/Symfony/Bundle/SecurityBundle/Resources/views/Collector/security.html.twig
Show resolved
Hide resolved
|
@javiereguiluz Hello, I remembered a discussion ago on this kind of subject here: +1 to remove the color if no security is involved in this profile :) |
|
the color for the toolbar info seems to be kept as is, using the removed variable. |
stof
reviewed
Nov 18, 2021
| {% set color_code = '' %} | ||
| {% endif %} | ||
|
|
||
| {% set is_authenticated = collector.enabled and collector.authenticated %} |
There was a problem hiding this comment.
As this variable is used only in the {% if collector.enabled and collector.token %} condition of the text, maybe the usage can be changed to collector.authenticated instead
There was a problem hiding this comment.
I've made some changes ... but I'm not sure if it's what you were asking for.
stof
approved these changes
Nov 18, 2021
fabpot
approved these changes
Nov 18, 2021
785d53c to
ccfce10
Compare
|
Thank you @javiereguiluz. |
This was referenced Nov 18, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 5.4, by default the Security panel in the toolbar displays a yellow background when there's no security:
I think this shouldn't be the case because a yellow background means: "Hey, look here because there's something you probably need to fix" But, it's OK if certain pages don't have any security, so there's no issue to fix.
After this PR, this is how it looks: