[WebProfilerBundle] Add a "preview" tab in mailer profiler for HTML email #43751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
709fb7d to
b5d55b4
Compare
stof
reviewed
Oct 26, 2021
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/mailer.html.twig
Outdated
Show resolved
Hide resolved
b5d55b4 to
aae2768
Compare
fabpot
approved these changes
Oct 29, 2021
|
Thank you @lyrixx. |
stof
reviewed
Oct 29, 2021
| <div class="tab"> | ||
| <h3 class="tab-title">HTML preview</h3> | ||
| <div class="tab-content"> | ||
| <pre class="prewrap" style="max-height: 600px"> |
There was a problem hiding this comment.
why using a pre tag as a wrapper of the iframe ?
There was a problem hiding this comment.
To force the mail "area"
But I might be removed, I did not test it.
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not work with mail for a long time, and I just discover the new entry in the profile. This is very nice 👏🏼
But I miss a preview rendering, so here we go