[Console] [Framework] Add completion to secrets:set and fix secrets:remove #43626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Oct 21, 2021
8aa3fa3 to
134e36e
Compare
|
Rebased on #43628. |
wouterj
reviewed
Oct 21, 2021
src/Symfony/Bundle/FrameworkBundle/Tests/Command/SecretsRemoveCommandTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Tests/Command/SecretsRemoveCommandTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Tests/Command/SecretsRemoveCommandTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Tests/Command/SecretsSetCommandTest.php
Outdated
Show resolved
Hide resolved
134e36e to
6f74cd8
Compare
54 tasks
fabpot
approved these changes
Oct 22, 2021
|
Thank you @GromNaN. |
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secrets:set(name)secrets:removewhen local vault is disabled and add tests.Upgrade the required version ofsymfony/consolesince commands cannot implement an interface that does not exist in older versions [Console] Implementing bash completion in a forward-compatible way #43620