[Messenger] fix: TypeError in PhpSerializer::encode() #43568
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Can you provide a test that covers your change? |
|
Fixed the code style and added a test, but not sure its naming is the best |
src/Symfony/Component/Messenger/Transport/Serialization/PhpSerializer.php
Outdated
Show resolved
Hide resolved
Ensure a MessageDecodingFailedException is thrown when the string to be unserialized is an empty string. This happens because unserializing an empty string does not issue a PHP warning, and simply returns false.
|
Thank you @dsech. |
Messenger does not throw a
MessageDecodingFailedExceptionfor some messages that have invalid bodies when using the native PHP serialize/deserialize format.This happens because unserializing an empty string does not issue a PHP warning, and simply returns false.