Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[HttpClient] Add method to set response factory in mock client #43280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2021
Merged

[HttpClient] Add method to set response factory in mock client #43280

merged 1 commit into from
Oct 5, 2021

Conversation

greeflas
Copy link
Contributor

@greeflas greeflas commented Oct 1, 2021

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #40620
License MIT
Doc PR symfony/symfony-docs#15883

@carsonbot carsonbot added this to the 5.4 milestone Oct 1, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

nicolas-grekas
nicolas-grekas approved these changes Oct 2, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(with minor comments)

src/Symfony/Component/HttpClient/CHANGELOG.md Outdated Show resolved Hide resolved
@greeflas greeflas force-pushed the ticket_40620_setter_for_response_factory branch from 7fe3331 to 59f7564 Compare October 2, 2021 10:04
@derrabus
Copy link
Member

derrabus commented Oct 4, 2021

Thank you for this PR. I agree with the changes, but I think we should add a test.

@nicolas-grekas nicolas-grekas force-pushed the ticket_40620_setter_for_response_factory branch from ae403bf to 2e028cc Compare October 5, 2021 07:51
@nicolas-grekas
Copy link
Member

Thank you @greeflas.

@nicolas-grekas nicolas-grekas merged commit 3e387cf into symfony:5.4 Oct 5, 2021
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@norkunas norkunas norkunas left review comments

@lmillucci lmillucci lmillucci left review comments

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Feature HttpClient Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[HttpClient] Allow MockHttpClient $responseFactory to be modifiable though accessors
6 participants
@greeflas @carsonbot @derrabus @nicolas-grekas @norkunas @lmillucci
Morty Proxy This is a proxified and sanitized view of the page, visit original site.