[DependencyInjection] fix support for "new" in initializers on PHP 8.1 #43277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Oct 1, 2021
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Part of #41552 |
| License | MIT |
| Doc PR | - |
nicolas-grekas
commented
Oct 1, 2021
src/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services_new_in_initializer.php
Show resolved
Hide resolved
02d428d to
36080f3
Compare
|
Hey! I think @fancyweb has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
stof
approved these changes
Oct 2, 2021
chalasr
approved these changes
Oct 3, 2021
derrabus
approved these changes
Oct 3, 2021
36080f3 to
523e45f
Compare
523e45f to
fae3659
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jan 11, 2023
…on-autowired services (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Fix support for named arguments on non-autowired services | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48818 | License | MIT | Doc PR | - This fixes support for named arguments on non-autowired services as described in #48818. Related to #43277 and #38091 Commits ------- a899bed [DependencyInjection] Fix support for named arguments on non-autowired services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.