Standardize Voter code

1. Change internal methods from public to protected 2. Remove useless phpdoc
symfony · yellow1912 · Sep 23, 2021 · Sep 23, 2021 · Sep 23, 2021 · Sep 23, 2021
commit 66d49ac74c7edd22b733428a5f2b433b268d17d5
@@ -71,23 +71,23 @@ public function vote(TokenInterface $token, $subject, array $attributes)
    /**
     * Creates a granted vote.
     */
-    public function grant(string $reason = '', array $parameters = []): Vote
+    protected function grant(string $reason = '', array $parameters = []): Vote
    {
        return Vote::createGranted($reason, $parameters);
    }

    /**
     * Creates an abstained vote.
     */
-    public function abstain(string $reason = '', array $parameters = []): Vote
+    protected function abstain(string $reason = '', array $parameters = []): Vote
    {
        return Vote::createAbstain($reason, $parameters);
    }

    /**
     * Creates a denied vote.
     */
-    public function deny(string $reason = '', array $parameters = []): Vote
+    protected function deny(string $reason = '', array $parameters = []): Vote
    {
        return Vote::createDenied($reason, $parameters);
    }
@@ -98,7 +98,6 @@ public function deny(string $reason = '', array $parameters = []): Vote
     * @param string $attribute An attribute
     * @param mixed  $subject   The subject to secure, e.g. an object the user wants to access or any other PHP type
     *
-     * @return bool True if the attribute and subject are supported, false otherwise
     */
    abstract protected function supports(string $attribute, $subject);

@@ -108,7 +107,7 @@ abstract protected function supports(string $attribute, $subject);
     *
     * @param mixed $subject
     *
-     * @return Vote Returning a boolean is deprecated since Symfony 5.1. Return a Vote object instead.
+     * @return Vote Returning a boolean is deprecated since Symfony 5.4. Return a Vote object instead.
     */
    abstract protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token);
 }