Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[DoctrineBridge] remove deprecated code #43100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2021
Merged

[DoctrineBridge] remove deprecated code #43100

merged 1 commit into from
Sep 21, 2021

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 20, 2021

Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 6.0 milestone Sep 20, 2021
@fabpot
Copy link
Member

fabpot commented Sep 21, 2021

Thank you @xabbuh.

@fabpot fabpot merged commit c0a4905 into symfony:6.0 Sep 21, 2021
@xabbuh xabbuh deleted the doctrine-bridge-legacy-code-cleanup branch September 21, 2021 13:10
@GromNaN GromNaN mentioned this pull request Jun 30, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Jun 30, 2023
@nicolas-grekas
minor #50828 [DoctrineBridge][HttpFoundation] Remove `ExpectDeprecati…
1eaefe3 
…onTrait` where it is not used (GromNaN)

This PR was merged into the 6.4 branch.

Discussion
----------

[DoctrineBridge][HttpFoundation] Remove `ExpectDeprecationTrait` where it is not used

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | n/a

This unused code has been left since 6.0 by #43100 and #43550.
The PR targets 6.4 because this is not a bug, but minor code cleanup.

Commits
-------

9317cbd Remove ExpectDeprecationTrait where it is not used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
DoctrineBridge Status: Reviewed
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @fabpot @nicolas-grekas @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.