[PropertyInfo] Support for the never return type

Signed-off-by: Alexander M. Turek <me@derrabus.de>
symfony · derrabus · Aug 23, 2021 · Aug 18, 2021 · Aug 18, 2021 · 091769a34954a2b91e25df22ef1a4c93bd5d9676
commit 091769a34954a2b91e25df22ef1a4c93bd5d9676
diff --git a/.github/patch-types.php b/.github/patch-types.php
@@ -42,6 +42,7 @@
        case false !== strpos($file, '/src/Symfony/Component/ErrorHandler/Tests/Fixtures/'):
        case false !== strpos($file, '/src/Symfony/Component/PropertyInfo/Tests/Fixtures/Dummy.php'):
        case false !== strpos($file, '/src/Symfony/Component/PropertyInfo/Tests/Fixtures/ParentDummy.php'):
+        case false !== strpos($file, '/src/Symfony/Component/PropertyInfo/Tests/Fixtures/Php81Dummy.php'):
        case false !== strpos($file, '/src/Symfony/Component/Serializer/Tests/Normalizer/Features/ObjectOuter.php'):
        case false !== strpos($file, '/src/Symfony/Component/VarDumper/Tests/Fixtures/NotLoadableClass.php'):
        case false !== strpos($file, '/src/Symfony/Component/VarDumper/Tests/Fixtures/ReflectionIntersectionTypeFixture.php'):

@@ -335,7 +335,7 @@ private function extractFromReflectionType(\ReflectionType $reflectionType, \Ref

        foreach ($reflectionType instanceof \ReflectionUnionType ? $reflectionType->getTypes() : [$reflectionType] as $type) {
            $phpTypeOrClass = $reflectionType instanceof \ReflectionNamedType ? $reflectionType->getName() : (string) $type;
-            if ('null' === $phpTypeOrClass || 'mixed' === $phpTypeOrClass) {
+            if ('null' === $phpTypeOrClass || 'mixed' === $phpTypeOrClass || 'never' === $phpTypeOrClass) {
                continue;
            }


@@ -233,7 +233,7 @@ public function php71TypesProvider()
    }

    /**
-     *     * @dataProvider php80TypesProvider
+     * @dataProvider php80TypesProvider
     * @requires PHP 8
     */
    public function testExtractPhp80Type($property, array $type = null)
@@ -255,6 +255,14 @@ public function php80TypesProvider()
        ];
    }

+    /**
+     * @requires PHP 8.1
+     */
+    public function testExtractPhp81Type()
+    {
+        $this->assertNull($this->extractor->getTypes('Symfony\Component\PropertyInfo\Tests\Fixtures\Php81Dummy', 'nothing', []));
+    }
+
    /**
     * @dataProvider defaultValueProvider
     */

@@ -0,0 +1,11 @@
+<?php
+
+namespace Symfony\Component\PropertyInfo\Tests\Fixtures;
+
+class Php81Dummy
+{
+    public function getNothing(): never
+    {
+        throw new \Exception('Oops');
+    }
+}
-Original file line number
+Diff line change
@@ -233,7 +233,7 @@ public function php71TypesProvider()
         }
         /**
-         *     * @dataProvider php80TypesProvider
             Copy link

  
      
    
  

  
      

  
  Member


      

  

  
    
      

      
            jderusse
  

      

      

      


        Aug 19, 2021


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      should be fixed upstream? right?
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    

    



  
        
  
    
        
    
  


      
          
  
      
            Copy link

  
      
    
  

  
      

  
  Member


      

  Author


  

  
    
      

      
            derrabus
  

      

      

      


        Aug 19, 2021


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      I think it's fine to fix it in this PR. I'm targeting our lowest branch already.
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
+         * @dataProvider php80TypesProvider
          * @requires PHP 8
          */
         public function testExtractPhp80Type($property, array $type = null)
@@ -255,6 +255,14 @@ public function php80TypesProvider()
             ];
         }
+        /**
+         * @requires PHP 8.1
+         */
+        public function testExtractPhp81Type()
+        {
+            $this->assertNull($this->extractor->getTypes('Symfony\Component\PropertyInfo\Tests\Fixtures\Php81Dummy', 'nothing', []));
+        }
         /**
          * @dataProvider defaultValueProvider
          */
-          Expand Down