Add return types - batch 1/n #42504
Merged
Add return types - batch 1/n #42504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d07ae36 to
81bf1f8
Compare
Member
Author
|
📗 (psalm failure are false-positives here.) |
derrabus
approved these changes
Aug 12, 2021
| * @return CacheItemPoolInterface | ||
| */ | ||
| public static function create(string $file, CacheItemPoolInterface $fallbackPool) | ||
| public static function create(string $file, CacheItemPoolInterface $fallbackPool): CacheItemPoolInterface |
Member
There was a problem hiding this comment.
Suggested change
| public static function create(string $file, CacheItemPoolInterface $fallbackPool): CacheItemPoolInterface | |
| public static function create(string $file, CacheItemPoolInterface $fallbackPool): static |
I don't quite understand why the previously annotated return type was so wide, tbh.
81bf1f8 to
1564887
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #42496 for components that shouldn't be extended very often.