Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Cleanup @return annotations #42495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

The goal of this patch is to allow php-cs-fixer to remove these annotations on 6.0 when native return types will be used.

Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I hope you used incredible regex skills to somewhat automate this and didn't have to go over all of them by hand.

(is even this something that we don't want to merge into 4.4?)

Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@derrabus
Copy link
Member

Thank you Nicolas.

@derrabus derrabus merged commit 646d9b0 into symfony:5.4 Aug 12, 2021
nicolas-grekas added a commit that referenced this pull request Aug 17, 2021
This PR was merged into the 5.4 branch.

Discussion
----------

Cleanup more ``@return`` annotations

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Follow up of #42495, same motivation.
Automated edits, manual selection, happy review :P

Commits
-------

8f36bbd Cleanup more ``@return`` annotations
hultberg pushed a commit to hultberg/symfony that referenced this pull request Sep 17, 2021
…kas)

This PR was merged into the 5.4 branch.

Discussion
----------

Cleanup more ``@return`` annotations

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Follow up of symfony#42495, same motivation.
Automated edits, manual selection, happy review :P

Commits
-------

8f36bbd Cleanup more ``@return`` annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.