-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Cleanup @return
annotations
#42495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup @return
annotations
#42495
Conversation
0bd42d8
to
561dae9
Compare
561dae9
to
8efde8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I hope you used incredible regex skills to somewhat automate this and didn't have to go over all of them by hand.
(is even this something that we don't want to merge into 4.4?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Thank you Nicolas. |
This PR was merged into the 5.4 branch. Discussion ---------- Cleanup more ``@return`` annotations | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follow up of #42495, same motivation. Automated edits, manual selection, happy review :P Commits ------- 8f36bbd Cleanup more ``@return`` annotations
…kas) This PR was merged into the 5.4 branch. Discussion ---------- Cleanup more ``@return`` annotations | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follow up of symfony#42495, same motivation. Automated edits, manual selection, happy review :P Commits ------- 8f36bbd Cleanup more ``@return`` annotations
The goal of this patch is to allow php-cs-fixer to remove these annotations on 6.0 when native return types will be used.