symfony · nicolas-grekas · Aug 11, 2021 · Jul 16, 2021
diff --git a/.github/patch-types.php b/.github/patch-types.php
@@ -15,6 +15,7 @@
    switch (true) {
        case false !== strpos($file = realpath($file), '/vendor/'):
        case false !== strpos($file, '/src/Symfony/Bridge/PhpUnit/'):
+        case false !== strpos($file, '/Attribute/'):
        case false !== strpos($file, '/src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Validation/Article.php'):
        case false !== strpos($file, '/src/Symfony/Component/Cache/Tests/Fixtures/DriverWrapper.php'):
        case false !== strpos($file, '/src/Symfony/Component/Config/Tests/Fixtures/BadFileName.php'):

@@ -856,6 +856,10 @@ public function onAuthenticationSuccess(Request $request, TokenInterface $token,
    public function onAuthenticationFailure(Request $request, AuthenticationException $exception): ?Response
    {
    }
+
+    public function createToken(Passport $passport, string $firewallName): TokenInterface
+    {
+    }
 }

 class NullAuthenticator implements GuardAuthenticatorInterface

diff --git a/src/Symfony/Component/Cache/Tests/Fixtures/ArrayCache.php b/src/Symfony/Component/Cache/Tests/Fixtures/ArrayCache.php
@@ -8,6 +8,9 @@ class ArrayCache extends CacheProvider
 {
    private $data = [];

+    /**
+     * @return mixed
+     */
    protected function doFetch($id)
    {
        return $this->doContains($id) ? $this->data[$id][0] : false;

diff --git a/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php
@@ -13,7 +13,6 @@

 use Symfony\Component\DependencyInjection\Alias;
 use Symfony\Component\DependencyInjection\Argument\AbstractArgument;
-use Symfony\Component\DependencyInjection\Argument\ArgumentInterface;
 use Symfony\Component\DependencyInjection\Argument\BoundArgument;
 use Symfony\Component\DependencyInjection\Argument\IteratorArgument;
 use Symfony\Component\DependencyInjection\Argument\ServiceClosureArgument;
@@ -803,9 +802,7 @@ private function validate($content, string $file): ?array
    }

    /**
-     * Resolves services.
-     *
-     * @return array|string|Reference|ArgumentInterface
+     * @return mixed
     */
    private function resolveServices($value, string $file, bool $isParameter = false)
    {

diff --git a/...Symfony/Component/DependencyInjection/Tests/Fixtures/includes/ProjectWithXsdExtension.php b/...Symfony/Component/DependencyInjection/Tests/Fixtures/includes/ProjectWithXsdExtension.php
@@ -2,7 +2,7 @@

 class ProjectWithXsdExtension extends ProjectExtension
 {
-    public function getXsdValidationBasePath()
+    public function getXsdValidationBasePath(): string
    {
        return __DIR__.'/schema';
    }

diff --git a/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MongoDbSessionHandler.php b/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MongoDbSessionHandler.php
@@ -82,6 +82,7 @@ public function __construct(\MongoDB\Client $mongo, array $options)
    /**
     * @return bool
     */
+    #[\ReturnTypeWillChange]
    public function close()
    {
        return true;
@@ -135,6 +136,7 @@ protected function doWrite(string $sessionId, string $data)
    /**
     * @return bool
     */
+    #[\ReturnTypeWillChange]
    public function updateTimestamp($sessionId, $data)
    {
        $expiry = new \MongoDB\BSON\UTCDateTime((time() + (int) ini_get('session.gc_maxlifetime')) * 1000);

diff --git a/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/RedisSessionHandler.php b/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/RedisSessionHandler.php
@@ -128,6 +128,7 @@ public function gc($maxlifetime)
    /**
     * @return bool
     */
+    #[\ReturnTypeWillChange]
    public function updateTimestamp($sessionId, $data)
    {
        return (bool) $this->redis->expire($this->prefix.$sessionId, (int) ($this->ttl ?? ini_get('session.gc_maxlifetime')));

diff --git a/src/Symfony/Component/HttpKernel/Tests/KernelTest.php b/src/Symfony/Component/HttpKernel/Tests/KernelTest.php
@@ -516,17 +516,20 @@ public function load(array $configs, ContainerBuilder $container)
                $container->setParameter('test.extension-registered', true);
            }

-            public function getNamespace()
+            public function getNamespace(): string
            {
                return '';
            }

+            /**
+             * @return false
+             */
            public function getXsdValidationBasePath()
            {
                return false;
            }

-            public function getAlias()
+            public function getAlias(): string
            {
                return 'test-extension';
            }

diff --git a/src/Symfony/Component/Ldap/Adapter/ExtLdap/Collection.php b/src/Symfony/Component/Ldap/Adapter/ExtLdap/Collection.php
@@ -65,6 +65,7 @@ public function count()
    /**
     * @return \Traversable
     */
+    #[\ReturnTypeWillChange]
    public function getIterator()
    {
        if (0 === $this->count()) {
@@ -91,6 +92,7 @@ public function getIterator()
    /**
     * @return bool
     */
+    #[\ReturnTypeWillChange]
    public function offsetExists($offset)
    {
        $this->toArray();
@@ -101,6 +103,7 @@ public function offsetExists($offset)
    /**
     * @return mixed
     */
+    #[\ReturnTypeWillChange]
    public function offsetGet($offset)
    {
        $this->toArray();
@@ -111,6 +114,7 @@ public function offsetGet($offset)
    /**
     * @return void
     */
+    #[\ReturnTypeWillChange]
    public function offsetSet($offset, $value)
    {
        $this->toArray();
@@ -121,6 +125,7 @@ public function offsetSet($offset, $value)
    /**
     * @return void
     */
+    #[\ReturnTypeWillChange]
    public function offsetUnset($offset)
    {
        $this->toArray();

diff --git a/src/Symfony/Component/Ldap/Tests/Security/CheckLdapCredentialsListenerTest.php b/src/Symfony/Component/Ldap/Tests/Security/CheckLdapCredentialsListenerTest.php
@@ -228,5 +228,9 @@ public function onAuthenticationSuccess(Request $request, TokenInterface $token,
        public function onAuthenticationFailure(Request $request, AuthenticationException $exception): ?Response
        {
        }
+
+        public function createToken(Passport $passport, string $firewallName): TokenInterface
+        {
+        }
    }
 }
@@ -456,7 +456,7 @@ public function delete(Key $key)
                unset($this->keys[spl_object_hash($key)]);
            }

-            public function exists(Key $key)
+            public function exists(Key $key): bool
            {
                return isset($this->keys[spl_object_hash($key)]);
            }
@@ -502,7 +502,7 @@ public function delete(Key $key)
                unset($this->keys[spl_object_hash($key)]);
            }

-            public function exists(Key $key)
+            public function exists(Key $key): bool
            {
                return isset($this->keys[spl_object_hash($key)]);
            }

@@ -52,6 +52,9 @@ public function isAuthenticated(): bool
                return true;
            }

+            /**
+             * @return mixed
+             */
            public function getCredentials()
            {
            }

@@ -619,6 +619,9 @@ public function setSerializer(SerializerInterface $serializer)

 class NotSerializable
 {
+    /**
+     * @return array
+     */
    public function __sleep()
    {
        if (class_exists(\Error::class)) {

@@ -601,9 +601,11 @@ public function testNormalizeNotSerializableContext()
    public function testDefaultExcludeFromCacheKey()
    {
        $normalizer = new class(null, null, null, null, null, null, [ObjectNormalizer::EXCLUDE_FROM_CACHE_KEY => ['foo']]) extends ObjectNormalizer {
-            protected function isCircularReference($object, &$context)
+            protected function isCircularReference($object, &$context): bool
            {
                ObjectNormalizerTest::assertContains('foo', $this->defaultContext[ObjectNormalizer::EXCLUDE_FROM_CACHE_KEY]);
+
+                return false;
            }
        };
        $normalizer->normalize(new ObjectDummy());

@@ -25,6 +25,7 @@ class TestNormalizer implements NormalizerInterface
     */
    public function normalize($object, string $format = null, array $context = [])
    {
+        return null;
    }

    /**