[Validator][Tests] Fix AssertingContextualValidator not throwing on remaining expectations #42458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @przemyslaw-bogusz has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
9b458d2 to
27d0fda
Compare
|
Shouldn't this be covered by some tests? |
27d0fda to
b409cb2
Compare
…emaining expectations
b409cb2 to
aac1013
Compare
|
I added a test. I reverted the assertEquals() for objects because it's in the case where you mutate the validated value in the validator (for example, the value in the validator is a string, you construct a \DateTime from it and you validate the \DateTime instance). I guess that could be considered as a bad practice so I decided I don't care for now. |
|
@fabpot @xabbuh @nicolas-grekas I'm attempting another ping on this one because it's a real bug and I would like it to be fixed 😅 |
|
Thank you @fancyweb. |
This was referenced Feb 28, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on something I noticed two missing things in the
AssertingContextualValidator.AssertingContextualValidatoris destroyed. Therefore the tests using it always pass, whether the validator actually callsvalidateor not. (for example: comment the->validate()line inAllValidatorand tests still pass)2. When the expected value / value is an object, we should useassertEqualsbecause it cannot logically be the same instance.Ping @xabbuh