Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Notifier] Autoconfigure chatter.transport_factory #42426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ismail1432
Copy link
Contributor

@ismail1432 ismail1432 commented Aug 8, 2021

Q A
Branch? 5.4
Bug fix? no
New feature? yes
License MIT
Doc PR symfony/symfony-docs#...

I'm wondering why we not autoconfigure chatter.transport_factory and texter.transport_factory with TransportFactoryInterface. It will avoid to manually tag the TransportFactory

@ismail1432 ismail1432 force-pushed the auto-register-chatter.transport_factory branch from 9b49e38 to d6d012c Compare August 8, 2021 23:44
@chalasr chalasr added this to the 5.4 milestone Aug 9, 2021
@fabpot
Copy link
Member

fabpot commented Aug 26, 2021

Thank you @ismail1432.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.