Field names must be string

symfony · wkania · Apr 11, 2021 · Aug 5, 2021 · Aug 5, 2021 · Aug 6, 2021
commit 5169f4acd335dcd8fc0a9fe9f2a427e817016f22
diff --git a/src/Symfony/Component/Validator/Constraints/UniqueValidator.php b/src/Symfony/Component/Validator/Constraints/UniqueValidator.php
@@ -79,6 +79,9 @@ private function reduceElementKeys(array $fields, array $element): array
    {
        $output = [];
        foreach ($fields as $field) {
+            if (!\is_string($field)) {
+                throw new UnexpectedTypeException($field, 'string');
+            }
            if (isset($element[$field])) {
                $output[$field] = $element[$field];
            }

diff --git a/src/Symfony/Component/Validator/Tests/Constraints/UniqueValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/UniqueValidatorTest.php
@@ -13,6 +13,7 @@

 use Symfony\Component\Validator\Constraints\Unique;
 use Symfony\Component\Validator\Constraints\UniqueValidator;
+use Symfony\Component\Validator\Exception\UnexpectedTypeException;
 use Symfony\Component\Validator\Exception\UnexpectedValueException;
 use Symfony\Component\Validator\Test\ConstraintValidatorTestCase;

@@ -228,10 +229,30 @@ public function testCollectionFieldsAreOptional()
        $this->assertNoViolation();
    }

+    /**
+     * @dataProvider getInvalidFieldNames
+     */
+    public function testCollectionFieldNamesMustBeString(string $type, mixed $field)
+    {
+        $this->expectException(UnexpectedTypeException::class);
+        $this->expectExceptionMessage(sprintf('Expected argument of type "string", "%s" given', $type));
+
+        $this->validator->validate([['value' => 5], ['id' => 1, 'value' => 6]], new Unique([$field]));
+    }
+
+    public function getInvalidFieldNames(): \Generator
+    {
+        return [
+            yield ['stdClass', new \stdClass()],
+            yield ['int', 2],
+            yield ['bool', false],
+        ];
+    }
+
    /**
     * @dataProvider getInvalidCollectionValues
     */
-    public function testInvalidCollectionValues($value, $fields)
+    public function testInvalidCollectionValues(array $value, array $fields)
    {
        $this->validator->validate($value, new Unique($fields, [
            'message' => 'myMessage',
@@ -243,18 +264,18 @@ public function testInvalidCollectionValues($value, $fields)
            ->assertRaised();
    }

-    public function getInvalidCollectionValues()
+    public function getInvalidCollectionValues(): \Generator
    {
        return [
-            yield 'unique string' => [[['lang' => 'eng', 'translation' => 'hi'], ['lang' => 'eng', 'translation' => 'hi'],
+            yield 'unique string' => [[['lang' => 'eng', 'translation' => 'hi'], ['lang' => 'eng', 'translation' => 'hello'],
            ], ['lang']],
            yield 'unique floats' => [[
                ['latitude' => 51.509865, 'longitude' => -0.118092, 'poi' => 'capital'],
                ['latitude' => 52.520008, 'longitude' => 13.404954],
                ['latitude' => 51.509865, 'longitude' => -0.118092],
            ], ['latitude', 'longitude']],
            yield 'unique int' => [[
-                ['id' => 1, 'email' => 'bar@email.com'], ['id' => 1, 'email' => 'bar@email.com'],
+                ['id' => 1, 'email' => 'bar@email.com'], ['id' => 1, 'email' => 'foo@email.com'],
            ], ['id']],
        ];
    }