Fix ServiceLocator indexing when service is decorated #42347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't recall why I did that. I guess it was necessary for my original implementation and it might very well be the case that the final implementation did not need the passes to be rearranged anymore. As long as the tests are green, I'm fine with the change. |
chalasr
approved these changes
Aug 3, 2021
derrabus
approved these changes
Aug 4, 2021
fabpot
approved these changes
Aug 6, 2021
|
Thank you @shyim. |
Merged
|
After the change I've got a lot of |
Okhoshi
added a commit
to Okhoshi/symfony
that referenced
this pull request
Oct 19, 2021
Okhoshi
added a commit
to Okhoshi/symfony
that referenced
this pull request
Oct 19, 2021
Okhoshi
added a commit
to Okhoshi/symfony
that referenced
this pull request
Oct 19, 2021
Okhoshi
added a commit
to Okhoshi/symfony
that referenced
this pull request
Oct 19, 2021
Okhoshi
added a commit
to Okhoshi/symfony
that referenced
this pull request
Oct 20, 2021
Bilge
reviewed
Dec 14, 2022
src/Symfony/Component/DependencyInjection/Tests/Compiler/ServiceLocatorTagPassTest.php
Show resolved
Hide resolved
chalasr
added a commit
that referenced
this pull request
Dec 14, 2022
This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Fix undefined class in test | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #42347 (comment) | License | MIT | Doc PR | - Commits ------- 949c304 [DI] Fix undefined class in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We save in our application the service id into the database to look up the service by a tagged locator (finding the service which handles the payment).
With Symfony 5.3 the keys are differed when the service is decorated, this breaks our application logic.
The problem has been introduced with the addition of autowired arguments. The Pass order has been changed (91fbc90#diff-b75bcd1c8a876c4e6f189c298e7c7133d1d3bc87e2a2876c40ab92a51df1093aR68)
Now the
ServiceLocatorTagPassruns after the decoration magic has been done.This PR moves the DecoratorServicePass back to the place where it was on 5.2 and previous versions