symfony · derrabus · Aug 4, 2021 · Jul 26, 2021
diff --git a/src/Symfony/Bridge/Doctrine/Tests/Validator/Constraints/UniqueEntityValidatorTest.php b/src/Symfony/Bridge/Doctrine/Tests/Validator/Constraints/UniqueEntityValidatorTest.php
@@ -827,6 +827,10 @@ public function resultWithEmptyIterator(): array

        return [
            [$entity, new class() implements \Iterator {
+                /**
+                 * @return mixed
+                 */
+                #[\ReturnTypeWillChange]
                public function current()
                {
                    return null;
@@ -837,19 +841,28 @@ public function valid(): bool
                    return false;
                }

-                public function next()
+                public function next(): void
                {
                }

+                /**
+                 * @return mixed
+                 */
+                #[\ReturnTypeWillChange]
                public function key()
                {
+                    return false;
                }

-                public function rewind()
+                public function rewind(): void
                {
                }
            }],
            [$entity, new class() implements \Iterator {
+                /**
+                 * @return mixed
+                 */
+                #[\ReturnTypeWillChange]
                public function current()
                {
                    return false;
@@ -860,15 +873,20 @@ public function valid(): bool
                    return false;
                }

-                public function next()
+                public function next(): void
                {
                }

+                /**
+                 * @return mixed
+                 */
+                #[\ReturnTypeWillChange]
                public function key()
                {
+                    return false;
                }

-                public function rewind()
+                public function rewind(): void
                {
                }
            }],

@@ -45,6 +45,7 @@ public function __construct(KernelInterface $kernel, string $rootDir, array $pat
    /**
     * @return \Traversable
     */
+    #[\ReturnTypeWillChange]
    public function getIterator()
    {
        if (null !== $this->templates) {

diff --git a/src/Symfony/Component/Config/Resource/GlobResource.php b/src/Symfony/Component/Config/Resource/GlobResource.php
@@ -102,6 +102,7 @@ public function __wakeup(): void
    /**
     * @return \Traversable
     */
+    #[\ReturnTypeWillChange]
    public function getIterator()
    {
        if (!file_exists($this->prefix) || (!$this->recursive && '' === $this->pattern)) {

@@ -98,8 +98,9 @@ public function getCommand()
    }

    /**
-     * @return Helper[]
+     * @return \Traversable<Helper>
     */
+    #[\ReturnTypeWillChange]
    public function getIterator()
    {
        return new \ArrayIterator($this->helpers);

diff --git a/src/Symfony/Component/DomCrawler/Crawler.php b/src/Symfony/Component/DomCrawler/Crawler.php
@@ -1149,6 +1149,7 @@ public function getNode($position)
    /**
     * @return int
     */
+    #[\ReturnTypeWillChange]
    public function count()
    {
        return \count($this->nodes);
@@ -1157,6 +1158,7 @@ public function count()
    /**
     * @return \ArrayIterator|\DOMNode[]
     */
+    #[\ReturnTypeWillChange]
    public function getIterator()
    {
        return new \ArrayIterator($this->nodes);

diff --git a/src/Symfony/Component/DomCrawler/Form.php b/src/Symfony/Component/DomCrawler/Form.php
@@ -321,6 +321,7 @@ public function all()
     *
     * @return bool true if the field exists, false otherwise
     */
+    #[\ReturnTypeWillChange]
    public function offsetExists($name)
    {
        return $this->has($name);
@@ -335,6 +336,7 @@ public function offsetExists($name)
     *
     * @throws \InvalidArgumentException if the field does not exist
     */
+    #[\ReturnTypeWillChange]
    public function offsetGet($name)
    {
        return $this->fields->get($name);
@@ -350,6 +352,7 @@ public function offsetGet($name)
     *
     * @throws \InvalidArgumentException if the field does not exist
     */
+    #[\ReturnTypeWillChange]
    public function offsetSet($name, $value)
    {
        $this->fields->set($name, $value);
@@ -362,6 +365,7 @@ public function offsetSet($name, $value)
     *
     * @return void
     */
+    #[\ReturnTypeWillChange]
    public function offsetUnset($name)
    {
        $this->fields->remove($name);

diff --git a/src/Symfony/Component/EventDispatcher/GenericEvent.php b/src/Symfony/Component/EventDispatcher/GenericEvent.php
@@ -123,6 +123,7 @@ public function hasArgument($key)
     *
     * @throws \InvalidArgumentException if key does not exist in $this->args
     */
+    #[\ReturnTypeWillChange]
    public function offsetGet($key)
    {
        return $this->getArgument($key);
@@ -136,6 +137,7 @@ public function offsetGet($key)
     *
     * @return void
     */
+    #[\ReturnTypeWillChange]
    public function offsetSet($key, $value)
    {
        $this->setArgument($key, $value);
@@ -148,6 +150,7 @@ public function offsetSet($key, $value)
     *
     * @return void
     */
+    #[\ReturnTypeWillChange]
    public function offsetUnset($key)
    {
        if ($this->hasArgument($key)) {
@@ -162,6 +165,7 @@ public function offsetUnset($key)
     *
     * @return bool
     */
+    #[\ReturnTypeWillChange]
    public function offsetExists($key)
    {
        return $this->hasArgument($key);
@@ -172,6 +176,7 @@ public function offsetExists($key)
     *
     * @return \ArrayIterator
     */
+    #[\ReturnTypeWillChange]
    public function getIterator()
    {
        return new \ArrayIterator($this->arguments);

diff --git a/src/Symfony/Component/Finder/Finder.php b/src/Symfony/Component/Finder/Finder.php
@@ -618,6 +618,7 @@ public function in($dirs)
     *
     * @throws \LogicException if the in() method has not been called
     */
+    #[\ReturnTypeWillChange]
    public function getIterator()
    {
        if (0 === \count($this->dirs) && 0 === \count($this->iterators)) {
@@ -702,6 +703,7 @@ public function hasResults()
     *
     * @return int
     */
+    #[\ReturnTypeWillChange]
    public function count()
    {
        return iterator_count($this->getIterator());

diff --git a/src/Symfony/Component/Finder/Iterator/CustomFilterIterator.php b/src/Symfony/Component/Finder/Iterator/CustomFilterIterator.php
@@ -46,6 +46,7 @@ public function __construct(\Iterator $iterator, array $filters)
     *
     * @return bool true if the value should be kept, false otherwise
     */
+    #[\ReturnTypeWillChange]
    public function accept()
    {
        $fileinfo = $this->current();

diff --git a/src/Symfony/Component/Finder/Iterator/DateRangeFilterIterator.php b/src/Symfony/Component/Finder/Iterator/DateRangeFilterIterator.php
@@ -38,6 +38,7 @@ public function __construct(\Iterator $iterator, array $comparators)
     *
     * @return bool true if the value should be kept, false otherwise
     */
+    #[\ReturnTypeWillChange]
    public function accept()
    {
        $fileinfo = $this->current();

diff --git a/src/Symfony/Component/Finder/Iterator/DepthRangeFilterIterator.php b/src/Symfony/Component/Finder/Iterator/DepthRangeFilterIterator.php
@@ -38,6 +38,7 @@ public function __construct(\RecursiveIteratorIterator $iterator, int $minDepth
     *
     * @return bool true if the value should be kept, false otherwise
     */
+    #[\ReturnTypeWillChange]
    public function accept()
    {
        return $this->getInnerIterator()->getDepth() >= $this->minDepth;

diff --git a/src/Symfony/Component/Finder/Iterator/ExcludeDirectoryFilterIterator.php b/src/Symfony/Component/Finder/Iterator/ExcludeDirectoryFilterIterator.php
@@ -52,6 +52,7 @@ public function __construct(\Iterator $iterator, array $directories)
     *
     * @return bool True if the value should be kept, false otherwise
     */
+    #[\ReturnTypeWillChange]
    public function accept()
    {
        if ($this->isRecursive && isset($this->excludedDirs[$this->getFilename()]) && $this->isDir()) {
@@ -71,6 +72,7 @@ public function accept()
    /**
     * @return bool
     */
+    #[\ReturnTypeWillChange]
    public function hasChildren()
    {
        return $this->isRecursive && $this->iterator->hasChildren();
@@ -79,6 +81,7 @@ public function hasChildren()
    /**
     * @return self
     */
+    #[\ReturnTypeWillChange]
    public function getChildren()
    {
        $children = new self($this->iterator->getChildren(), []);

diff --git a/src/Symfony/Component/Finder/Iterator/FileTypeFilterIterator.php b/src/Symfony/Component/Finder/Iterator/FileTypeFilterIterator.php
@@ -39,6 +39,7 @@ public function __construct(\Iterator $iterator, int $mode)
     *
     * @return bool true if the value should be kept, false otherwise
     */
+    #[\ReturnTypeWillChange]
    public function accept()
    {
        $fileinfo = $this->current();

diff --git a/src/Symfony/Component/Finder/Iterator/FilecontentFilterIterator.php b/src/Symfony/Component/Finder/Iterator/FilecontentFilterIterator.php
@@ -24,6 +24,7 @@ class FilecontentFilterIterator extends MultiplePcreFilterIterator
     *
     * @return bool true if the value should be kept, false otherwise
     */
+    #[\ReturnTypeWillChange]
    public function accept()
    {
        if (!$this->matchRegexps && !$this->noMatchRegexps) {

diff --git a/src/Symfony/Component/Finder/Iterator/FilenameFilterIterator.php b/src/Symfony/Component/Finder/Iterator/FilenameFilterIterator.php
@@ -25,6 +25,7 @@ class FilenameFilterIterator extends MultiplePcreFilterIterator
     *
     * @return bool true if the value should be kept, false otherwise
     */
+    #[\ReturnTypeWillChange]
    public function accept()
    {
        return $this->isAccepted($this->current()->getFilename());

diff --git a/src/Symfony/Component/Finder/Iterator/PathFilterIterator.php b/src/Symfony/Component/Finder/Iterator/PathFilterIterator.php
@@ -24,6 +24,7 @@ class PathFilterIterator extends MultiplePcreFilterIterator
     *
     * @return bool true if the value should be kept, false otherwise
     */
+    #[\ReturnTypeWillChange]
    public function accept()
    {
        $filename = $this->current()->getRelativePathname();

diff --git a/src/Symfony/Component/Finder/Iterator/SizeRangeFilterIterator.php b/src/Symfony/Component/Finder/Iterator/SizeRangeFilterIterator.php
@@ -38,6 +38,7 @@ public function __construct(\Iterator $iterator, array $comparators)
     *
     * @return bool true if the value should be kept, false otherwise
     */
+    #[\ReturnTypeWillChange]
    public function accept()
    {
        $fileinfo = $this->current();

diff --git a/src/Symfony/Component/Finder/Iterator/SortableIterator.php b/src/Symfony/Component/Finder/Iterator/SortableIterator.php
@@ -81,6 +81,7 @@ public function __construct(\Traversable $iterator, $sort, bool $reverseOrder =
    /**
     * @return \Traversable
     */
+    #[\ReturnTypeWillChange]
    public function getIterator()
    {
        if (1 === $this->sort) {

diff --git a/src/Symfony/Component/Finder/Tests/Iterator/Iterator.php b/src/Symfony/Component/Finder/Tests/Iterator/Iterator.php
@@ -23,12 +23,12 @@ public function __construct(array $values = [])
        $this->rewind();
    }

-    public function attach(\SplFileInfo $fileinfo)
+    public function attach(\SplFileInfo $fileinfo): void
    {
        $this->values[] = $fileinfo;
    }

-    public function rewind()
+    public function rewind(): void
    {
        reset($this->values);
    }
@@ -38,16 +38,24 @@ public function valid(): bool
        return false !== $this->current();
    }

-    public function next()
+    public function next(): void
    {
        next($this->values);
    }

+    /**
+     * @return mixed
+     */
+    #[\ReturnTypeWillChange]
    public function current()
    {
        return current($this->values);
    }

+    /**
+     * @return mixed
+     */
+    #[\ReturnTypeWillChange]
    public function key()
    {
        return key($this->values);

diff --git a/src/Symfony/Component/Finder/Tests/Iterator/MultiplePcreFilterIteratorTest.php b/src/Symfony/Component/Finder/Tests/Iterator/MultiplePcreFilterIteratorTest.php
@@ -54,7 +54,7 @@ public function __construct()
    {
    }

-    public function accept()
+    public function accept(): bool
    {
        throw new \BadFunctionCallException('Not implemented');
    }

@@ -51,6 +51,7 @@ public function __construct(FormConfigInterface $config)
     *
     * @return bool Always returns false
     */
+    #[\ReturnTypeWillChange]
    public function offsetExists($offset)
    {
        return false;
@@ -67,6 +68,7 @@ public function offsetExists($offset)
     *
     * @throws BadMethodCallException
     */
+    #[\ReturnTypeWillChange]
    public function offsetGet($offset)
    {
        throw new BadMethodCallException('Buttons cannot have children.');
@@ -84,6 +86,7 @@ public function offsetGet($offset)
     *
     * @throws BadMethodCallException
     */
+    #[\ReturnTypeWillChange]
    public function offsetSet($offset, $value)
    {
        throw new BadMethodCallException('Buttons cannot have children.');
@@ -100,6 +103,7 @@ public function offsetSet($offset, $value)
     *
     * @throws BadMethodCallException
     */
+    #[\ReturnTypeWillChange]
    public function offsetUnset($offset)
    {
        throw new BadMethodCallException('Buttons cannot have children.');
@@ -436,6 +440,7 @@ public function createView(FormView $parent = null)
     *
     * @return int Always returns 0
     */
+    #[\ReturnTypeWillChange]
    public function count()
    {
        return 0;
@@ -446,6 +451,7 @@ public function count()
     *
     * @return \EmptyIterator Always returns an empty iterator
     */
+    #[\ReturnTypeWillChange]
    public function getIterator()
    {
        return new \EmptyIterator();