[Translation] [Lokalise] Fix base_uri
#42243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Jul 23, 2021
OskarStark
approved these changes
Jul 23, 2021
|
Can you please add a testcase to expect the correct url? |
17fee77 to
e5fc67a
Compare
welcoMattic
commented
Jul 23, 2021
src/Symfony/Component/Translation/Bridge/Lokalise/Tests/LokaliseProviderFactoryTest.php
Outdated
Show resolved
Hide resolved
e5fc67a to
e235a98
Compare
OskarStark
reviewed
Jul 23, 2021
src/Symfony/Component/Translation/Bridge/Lokalise/Tests/LokaliseProviderFactoryTest.php
Outdated
Show resolved
Hide resolved
3bbf817 to
46c9b36
Compare
base_uri
OskarStark
approved these changes
Jul 24, 2021
fabpot
approved these changes
Jul 24, 2021
|
Thank you @welcoMattic. |
46c9b36 to
7390dc2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes the Lokalise
base_urivalue.