Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Console] fix table setHeaderTitle without headers #42207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2021
Merged

[Console] fix table setHeaderTitle without headers #42207

merged 1 commit into from
Jul 21, 2021

Conversation

a1812
Copy link
Contributor

@a1812 a1812 commented Jul 20, 2021 •
edited by OskarStark
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #42196
License MIT
Doc PR

fix bug

@a1812 a1812 requested a review from chalasr as a code owner July 20, 2021 17:04
@carsonbot carsonbot added this to the 4.4 milestone Jul 20, 2021
OskarStark
OskarStark reviewed Jul 20, 2021
View reviewed changes
src/Symfony/Component/Console/Helper/Table.php Outdated Show resolved Hide resolved
OskarStark
OskarStark reviewed Jul 20, 2021
View reviewed changes
src/Symfony/Component/Console/Tests/Helper/TableTest.php Outdated Show resolved Hide resolved
@a1812
Copy link
Contributor Author

a1812 commented Jul 21, 2021

Hi @OskarStark, what do you think about reworking the test "testSetTitle" and include testSetTitle2 in it ?

@OskarStark
Copy link
Contributor

IMHO the second test case in your new data provider is already included in the testSetTitle data provider.

So a test case testSetTitleWithoutHeaders without a data provider would be my favorite

OskarStark
OskarStark reviewed Jul 21, 2021
View reviewed changes
src/Symfony/Component/Console/Tests/Helper/TableTest.php Outdated Show resolved Hide resolved
OskarStark
OskarStark reviewed Jul 21, 2021
View reviewed changes
src/Symfony/Component/Console/Helper/Table.php Outdated Show resolved Hide resolved
@a1812 a1812 force-pushed the fix_issue_42196 branch from b5e2a28 to eabf778 Compare July 21, 2021 09:52
@chalasr
Copy link
Member

chalasr commented Jul 21, 2021

Thank you @a1812.

@chalasr chalasr merged commit 24a993a into symfony:4.4 Jul 21, 2021
@a1812 a1812 deleted the fix_issue_42196 branch July 21, 2021 10:46
This was referenced Jul 26, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Console Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@a1812 @OskarStark @chalasr @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.