Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add return type unions to private/internal/final/test methods #42203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2021
Merged

Add return type unions to private/internal/final/test methods #42203

merged 1 commit into from
Jul 21, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Spotted thanks to progress made on #42149

@nicolas-grekas nicolas-grekas added this to the 6.0 milestone Jul 20, 2021
@nicolas-grekas nicolas-grekas force-pushed the union-ret-types branch 7 times, most recently from 9b68a5d to e2dac76 Compare July 20, 2021 14:46
Tobion
Tobion reviewed Jul 21, 2021
View reviewed changes
src/Symfony/Component/Console/Helper/QuestionHelper.php Outdated Show resolved Hide resolved
Tobion
Tobion reviewed Jul 21, 2021
View reviewed changes
src/Symfony/Component/Templating/Tests/Loader/CacheLoaderTest.php Outdated Show resolved Hide resolved
@nicolas-grekas nicolas-grekas merged commit eaa80d9 into symfony:6.0 Jul 21, 2021
@nicolas-grekas nicolas-grekas deleted the union-ret-types branch July 23, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobion Tobion Tobion left review comments

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@sroze sroze Awaiting requested review from sroze

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @Tobion @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.