[Mailer] Make sure Http TransportException is not leaking #42184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82a061e to
f888d56
Compare
OskarStark
approved these changes
Jul 19, 2021
|
One minor question, why not against |
src/Symfony/Component/Mailer/Bridge/Mailgun/Transport/MailgunApiTransport.php
Outdated
Show resolved
Hide resolved
| } catch (TransportExceptionInterface $e) { | ||
| throw new HttpTransportException('Could not reach the remote Mailgun server.', $response, 0, $e); | ||
| } | ||
|
|
||
| if (200 !== $response->getStatusCode()) { |
There was a problem hiding this comment.
I'd wrap the call to getStatusCode and toArray in the same try/catch (same everywhere)
There was a problem hiding this comment.
Sure. I will but why? This will never throw TransportExceptionInterface if I first get the body.
There was a problem hiding this comment.
I'd say to make things easy to reason about and consistent (some places were calling getStatusCode before toArray/getContent)
f888d56 to
1681bc1
Compare
|
The PR is updated. I've targeted 4.4 and made sure we get both status code and body inside the try/catch |
nicolas-grekas
approved these changes
Jul 20, 2021
|
Thank you @Nyholm. |
This was referenced Jul 26, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We dont want the mailer to throw exceptions from the http-client component. This will make sure to catch such exceptions and rethrow the proper HttpTransportException from the Mailer component.