Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[CI] Fix wrongly skipped integration tests #42171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2021

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Jul 18, 2021

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

The integration tests from bridges located in components (e.g. Notifier/Bridge/Discord/Tests or Messenger/Bridge/Redis/Tests) were excluded from the CI.

Spotted while working on #42163 - Some redis-messenger tests are currently broken on 5.x, which we didn't spot because of the missing entry in the phpunit config.

@carsonbot carsonbot added this to the 4.4 milestone Jul 18, 2021
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍🏻

@derrabus
Copy link
Member

Good catch, thanks Robin.

@derrabus derrabus merged commit fa74feb into symfony:4.4 Jul 18, 2021
@chalasr chalasr deleted the msg-bridge-tests branch July 18, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.