[HttpFoundation] fix FileBag under PHP 8.1 #42112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think is the correct fix. I think we might want to get this new information into \Symfony\Component\HttpFoundation\File\UploadedFile - but the list of hardcoded keys is not that fun. |
|
Maybe this is good enough for 4.4, and we need to improve |
|
@nicolas-grekas taking this approach in 4.4 seems reasonable. I've not got time atm for PR for 5.4. Working through well over 1000 fails for the Drupal test suite on PHP 8.1 :D |
nicolas-grekas
approved these changes
Jul 15, 2021
derrabus
approved these changes
Jul 15, 2021
426c0c8 to
dc35049
Compare
|
Thank you @alexpott. |
This was referenced Jul 26, 2021
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Dec 4, 2023
…ath()` to support directory uploads (danielburger1337) This PR was merged into the 7.1 branch. Discussion ---------- [HttpFoundation] Add `UploadedFile::getClientOriginalPath()` to support directory uploads | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | License | MIT This removes the "hotfix" #42112 and now supports "full_path" PHP file uploads. Since PHP 8.1 is now the lowest allowed version of PHP, this shouldnt cause any problems. --- Although I'm quite certain that I understand the messy FileBag code, I'm very concerned for the potential impact this change might have because of the widespread use of http-foundation. To the best of my knowledge, this won't break Symfony BC (yet) because this is all done by an `optional` argument in the constructor of UploadedFile (this should eventually be replaced by a mandatory argument though). Also, I'm not quite happy with the tests. Since this is only a "passthrough" of the PHP value, this _shouldnt_ be a huge problem. Someone should definitly go through this change very carefully. The tests pass and I also threw some "real world" application tests at it and everything seems to work just fine. But because of the nature of HttpFoundation and its intangled mess, I can't guarantee that I accounted for every possible or even simple edge case. --- Though it would be nice to still see this in 7.0, I know that it will probably be pushed back to 7.1. Commits ------- dac592b [HttpFoundation] Add `UploadedFile::getClientOriginalPath()` to support directory uploads
symfony-splitter
pushed a commit
to symfony/form
that referenced
this pull request
Dec 4, 2023
…ath()` to support directory uploads (danielburger1337) This PR was merged into the 7.1 branch. Discussion ---------- [HttpFoundation] Add `UploadedFile::getClientOriginalPath()` to support directory uploads | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | License | MIT This removes the "hotfix" symfony/symfony#42112 and now supports "full_path" PHP file uploads. Since PHP 8.1 is now the lowest allowed version of PHP, this shouldnt cause any problems. --- Although I'm quite certain that I understand the messy FileBag code, I'm very concerned for the potential impact this change might have because of the widespread use of http-foundation. To the best of my knowledge, this won't break Symfony BC (yet) because this is all done by an `optional` argument in the constructor of UploadedFile (this should eventually be replaced by a mandatory argument though). Also, I'm not quite happy with the tests. Since this is only a "passthrough" of the PHP value, this _shouldnt_ be a huge problem. Someone should definitly go through this change very carefully. The tests pass and I also threw some "real world" application tests at it and everything seems to work just fine. But because of the nature of HttpFoundation and its intangled mess, I can't guarantee that I accounted for every possible or even simple edge case. --- Though it would be nice to still see this in 7.0, I know that it will probably be pushed back to 7.1. Commits ------- dac592b513 [HttpFoundation] Add `UploadedFile::getClientOriginalPath()` to support directory uploads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://php.watch/versions/8.1/$_FILES-full-path - in \Symfony\Component\HttpFoundation\FileBag::convertFileInformation() we check against a list of hardcoded keys. This logic breaks in PHP 8.1 because of the new key.