Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[ExpressionLanguage] Add types to private properties #42104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2021
Merged

[ExpressionLanguage] Add types to private properties #42104

merged 1 commit into from
Jul 15, 2021

Conversation

derrabus
Copy link
Member

Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 6.0 milestone Jul 14, 2021
derrabus
derrabus commented Jul 14, 2021
View reviewed changes
src/Symfony/Component/ExpressionLanguage/ExpressionFunction.php Outdated Show resolved Hide resolved
Tobion
Tobion reviewed Jul 14, 2021
View reviewed changes
src/Symfony/Component/ExpressionLanguage/Parser.php Outdated Show resolved Hide resolved
Tobion
Tobion reviewed Jul 14, 2021
View reviewed changes
src/Symfony/Component/ExpressionLanguage/Parser.php Outdated Show resolved Hide resolved
@derrabus derrabus force-pushed the types/expression-language-properties branch from 84fb0cd to 304cf32 Compare July 14, 2021 23:07
@derrabus derrabus mentioned this pull request Jul 15, 2021
Merged
derrabus added a commit that referenced this pull request Jul 15, 2021
@derrabus
feature #42127 [ExpressionLanguage] Store compiler and evaluator as c…
5ebb1fe 
…losures (derrabus)

This PR was merged into the 5.4 branch.

Discussion
----------

[ExpressionLanguage] Store compiler and evaluator as closures

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | #42104 (comment)
| License       | MIT
| Doc PR        | N/A

Commits
-------

1a4e5b1 [ExpressionLanguage] Store compiler and evaluator as closures
@derrabus
[ExpressionLanguage] Add types to private properties
276491b 
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabus derrabus force-pushed the types/expression-language-properties branch from 304cf32 to 276491b Compare July 15, 2021 14:11
@derrabus derrabus merged commit 71b90db into symfony:6.0 Jul 15, 2021
@derrabus derrabus deleted the types/expression-language-properties branch July 15, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@Tobion Tobion Tobion approved these changes

Assignees
No one assigned
Labels
ExpressionLanguage Status: Reviewed
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@derrabus @nicolas-grekas @Tobion @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.