[VarDumper] Support for intersection types #42099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
derrabus
commented
Jul 14, 2021
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | #41552 |
| License | MIT |
| Doc PR | N/A |
71f5490 to
bbe8260
Compare
Signed-off-by: Alexander M. Turek <me@derrabus.de>
bbe8260 to
3cf1057
Compare
derrabus
commented
Jul 14, 2021
Comment on lines
+326
to
+337
| types: array:2 [ | ||
| 0 => ReflectionNamedType { | ||
| name: "Traversable" | ||
| allowsNull: false | ||
| isBuiltin: false | ||
| } | ||
| 1 => ReflectionNamedType { | ||
| name: "Countable" | ||
| allowsNull: false | ||
| isBuiltin: false | ||
| } | ||
| ] |
There was a problem hiding this comment.
I've decided to match the generated output for ReflectionUnionType here. This is a bit verbose though because the sub-types of an intersection are guaranteed to be a ReflectionNamedType with $allowsNull === false and $isBuiltin === false.
There was a problem hiding this comment.
Actually, nullable intersection types are possible, see https://3v4l.org/aURFN/rfc#vgit.master
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh well. It's not like I haven't told them. 🤷🏻 php/php-src#6799 (comment)
There was a problem hiding this comment.
The loophole was closed. php/php-src#7254
|
Thank you @derrabus. |
This was referenced Jul 26, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.