Add a Special Case for Translating Choices in en_US_POSIX #42068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See symfony#42036 This adds a special case similar to `pt_BR` for handling `en_US_POSIX` which is set as the default locale on some operating systems (Alpine Linux, for instance).
a3d080c to
f0bb7a3
Compare
nicolas-grekas
approved these changes
Jul 12, 2021
|
Thank you @chrisguitarguy. |
This was referenced Jul 26, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a special case similar to
pt_BRfor handlingen_US_POSIXwhich is set as the default locale on some operating systems.
Two tests here might be over the top, not sure.Not over the top! One of them caught the same issue in the translation component itself 🎉