[HttpKernel] recover from failed deserializations #42032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jul 8, 2021
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #42031 |
| License | MIT |
| Doc PR |
| @@ -298,7 +298,7 @@ private function getMetadata(string $key): array | ||
| return []; | ||
| } | ||
|
|
||
| return unserialize($entries); | ||
| return unserialize($entries) ?: []; |
There was a problem hiding this comment.
unserialize can return various types (see https://www.php.net/manual/en/function.unserialize.php#refsect1-function.unserialize-returnvalues).
Maybe we should test the return value with is_array ?
There was a problem hiding this comment.
Well, the Store controls the serialization too. So if unserializing does not fail, we know that we have an array (unless you messed up with the files directly to change what is stored, but that's not supported by our implementation)
|
Thank you @xabbuh. |
|
Thank you @xabbuh ! |
This was referenced Jul 26, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.