symfony · nicolas-grekas · Jul 4, 2021 · Jul 3, 2021 · Jul 4, 2021 · Jul 4, 2021
@@ -106,12 +106,10 @@ public function getArguments()
     */
    public function getArgument($name)
    {
-        if (!$this->definition->hasArgument($name)) {
+        if (!$this->definition->hasArgument((string) $name)) {
            throw new InvalidArgumentException(sprintf('The "%s" argument does not exist.', $name));
        }

-        $name = \is_int($name) ? key(\array_slice($this->definition->getArguments(), $name, 1, true)) : $name;
-
        return $this->arguments[$name] ?? $this->definition->getArgument($name)->getDefault();
    }

@@ -120,12 +118,10 @@ public function getArgument($name)
     */
    public function setArgument($name, $value)
    {
-        if (!$this->definition->hasArgument($name)) {
+        if (!$this->definition->hasArgument((string) $name)) {
            throw new InvalidArgumentException(sprintf('The "%s" argument does not exist.', $name));
        }

-        $name = \is_int($name) ? key(\array_slice($this->definition->getArguments(), $name, 1, true)) : $name;
-
        $this->arguments[$name] = $value;
    }

@@ -134,7 +130,7 @@ public function setArgument($name, $value)
     */
    public function hasArgument($name)
    {
-        return $this->definition->hasArgument($name);
+        return $this->definition->hasArgument((string) $name);
    }

    /**

@@ -83,7 +83,7 @@ public function getArguments();
    /**
     * Returns the argument value for a given argument name.
     *
-     * @param string|int $name The InputArgument name or position
+     * @param string $name The argument name
     *
     * @return mixed
     *
@@ -94,8 +94,8 @@ public function getArgument($name);
    /**
     * Sets an argument value by name.
     *
-     * @param string|int $name  The InputArgument name or position
-     * @param mixed      $value The argument value
+     * @param string $name  The argument name
+     * @param mixed  $value The argument value
     *
     * @throws InvalidArgumentException When argument given doesn't exist
     */
@@ -104,7 +104,7 @@ public function setArgument($name, $value);
    /**
     * Returns true if an InputArgument object exists by name or position.
     *
-     * @param string|int $name The InputArgument name or position
+     * @param string $name The InputArgument name or position
     *
     * @return bool true if the InputArgument object exists, false otherwise
     */

@@ -75,11 +75,6 @@ public function testArguments()
        $input = new ArrayInput(['name' => 'foo'], new InputDefinition([new InputArgument('name'), new InputArgument('bar', InputArgument::OPTIONAL, '', 'default')]));
        $this->assertEquals('default', $input->getArgument('bar'), '->getArgument() returns the default value for optional arguments');
        $this->assertEquals(['name' => 'foo', 'bar' => 'default'], $input->getArguments(), '->getArguments() returns all argument values, even optional ones');
-
-        $input = new ArrayInput(['arg1' => 'foo'], new InputDefinition([new InputArgument('arg1'), new InputArgument('arg2')]));
-        $input->setArgument(1, 'bar');
-        $this->assertEquals('bar', $input->getArgument(1));
-        $this->assertEquals(['arg1' => 'foo', 'arg2' => 'bar'], $input->getArguments());
    }

    public function testSetInvalidArgument()