Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Rethrow exception in DoctrineTokenProvider #41917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2021
Merged

Rethrow exception in DoctrineTokenProvider #41917

merged 1 commit into from
Jul 3, 2021

Conversation

jderusse
Copy link
Member

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Introduced in #41910

@jderusse jderusse requested review from chalasr and wouterj as code owners June 30, 2021 12:06
@carsonbot carsonbot added this to the 5.3 milestone Jun 30, 2021
derrabus
derrabus approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should use Connection::transactional() instead that would handle this try/catch magic for us.

Note that the transaction would neither commit nor roll back if an Error is raised.

@fabpot
Copy link
Member

fabpot commented Jul 3, 2021

Thank you @jderusse.

@fabpot fabpot merged commit 2db1871 into symfony:5.3 Jul 3, 2021
@fabpot fabpot mentioned this pull request Jul 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

@derrabus derrabus derrabus approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
5 participants
@jderusse @fabpot @stof @derrabus @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.