correct the called event listener method case #41876
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
this changes no need extra tests. |
| @@ -81,7 +81,7 @@ public function process(ContainerBuilder $container) | ||
|
|
||
| if (!isset($event['method'])) { | ||
| $event['method'] = 'on'.preg_replace_callback([ | ||
| '/(?<=\b)[a-z]/i', | ||
| '/(?<=[\b\._])[a-z]/i', |
There was a problem hiding this comment.
I will check it later, but I replaced \b with [\b\._], this will match three elements, which make kernel.controller_arguments to be KernelControllerArguments, the origin result is KernelControllerarguments and the case of word after _ is wrong
|
closed, go #41905 |
I found that the actual method's case of event listener was wrong, when no method was specified, for example, event name:
kernel.controller_arguments, expected default method name:onkernelControllerArguments, actual method called:onKernelControllerarguments, but actually it's ok, php is case-insenstive for function call.ps, a service.yaml example: