Fix Url Validator false positives #41684
Conversation
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
|
Thank you for this PR. It looks like you are just adding some more test cases. Did you miss to add the patch? |
|
@Nyholm I didn't forget to push the patch as I'm still thinking how to cover all cases. BTW I'm open to any help :) |
36ab553 to
9181c4a
Compare
9181c4a to
952670f
Compare
|
Ready for review. |
a32529e to
074539d
Compare
|
Thank you @sidz. |
This PR tries to fix false positive issues with a couple of variants of domain names which Url validator thinks that they are valid
Url Validator returns false positive result on cases: