[Translation] Remove PoEditor Provider #41451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2021
stof
approved these changes
May 29, 2021
derrabus
approved these changes
May 30, 2021
OskarStark
approved these changes
May 30, 2021
fabpot
approved these changes
May 31, 2021
|
Thank you @welcoMattic. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it has been discussed in #41374, we have to remove the support of PoEditor as Translation Provider. The
translation:pullcommand do not work as expected with PoEditor, translations keys are not retrieved as they do.I contacted PoEditor support in order to fix the bug (it miss the
resnameattribute oftrans-unittag in their XLIFF 1.2 export files). I will follow up their change in the next coming weeks/months, and I hope we could re-add the PoEditor Provider in Symfony for 5.4/6.0.