Remove deprecated User from serialized test fixture
#41385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User from serialized test fixture
chalasr
approved these changes
May 23, 2021
|
Oh... I was pretty sure that this fixture was already upgraded in a PR of mine on 5.3 but actually, the upgraded fixture ended up in the wrong directory (1 level up): https://github.com/symfony/symfony/blob/5.3/src/Symfony/Component/Security/Core/Tests/Authentication/Token/switch-user-token-4.4.txt |
3f3544b to
ba2ae4e
Compare
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwitchUserTokenTesttests if a token serialized with Symfony 4.4 can still be unserialized. The serialized fixture however used the now-deprecatedSymfony\Component\Security\Core\User\User. This PR replaces that class with a new custom user class, which should make the test more resilient.