Fix SkippedTestSuite #41384
Merged
Fix SkippedTestSuite #41384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3b95e1 to
28857b7
Compare
|
But this method is now |
|
Issue opened in sebastianbergmann/phpunit#4689 |
28857b7 to
38f0fe9
Compare
|
As there is no feedback upstream, can we merge this one in the meantime? |
fabpot
approved these changes
Jul 4, 2021
|
Thank you @jderusse. |
1 similar comment
|
Thank you @jderusse. |
This was referenced Jul 26, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwing a TestSkipped in a
setUpBeforeClasssi handled by PHP unit as a standard exception, leading to a generic exceptionTest skipped because of an error in hook method(see https://github.com/symfony/symfony/pull/41380/checks?check_run_id=2645369759#step:14:165)However phpunit is able to catch
SkippedTestSuiteErrorin such situation.(https://github.com/sebastianbergmann/phpunit/blob/master/src/Framework/TestSuite.php#L438-L448)This PR replaces
self::markTestSkippedbythrow new SkippedTestSuiteError(we don't have static method helper for this exception) in oursetUpBeforeClassmethods.