[Mailer] Remove deprecated code #41308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jderusse
commented
May 20, 2021
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
bc88c9d to
628214f
Compare
derrabus
reviewed
May 20, 2021
src/Symfony/Component/Mailer/Bridge/Mailgun/Transport/MailgunApiTransport.php
Outdated
Show resolved
Hide resolved
|
Blocked by #41380 |
nicolas-grekas
added a commit
that referenced
this pull request
May 23, 2021
This PR was merged into the 5.2 branch. Discussion ---------- Make Mailgun Header compatible with other Bridges | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This revert deprecating passing a header without the required Mailgun `h:` prefix. And makes the bridge compatible with other bridges. See: - #36148 (comment) - #41308 (comment) Commits ------- 82f1f9c Make Mailgun Header compatible with other Bridges
|
Now unblocked |
derrabus
requested changes
May 23, 2021
derrabus
approved these changes
May 24, 2021
| --- | ||
|
|
||
| * Remove the `SesApiTransport` class. Use `SesApiAsyncAwsTransport` instead | ||
| * Remove the `SesHttpTransport` class. Use `SesHttpAsyncAwsTransport` instead |
There was a problem hiding this comment.
missing space at start of line (please rebase while fixing)
There was a problem hiding this comment.
there is no reason to put a space before the * of a markdown list
There was a problem hiding this comment.
for markdown no, for consistency yes
e0ee6f9 to
f33c05f
Compare
|
Thank you @jderusse. |
symfony-splitter
pushed a commit
to symfony/mailer
that referenced
this pull request
Sep 28, 2021
This PR was merged into the 5.2 branch. Discussion ---------- Make Mailgun Header compatible with other Bridges | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This revert deprecating passing a header without the required Mailgun `h:` prefix. And makes the bridge compatible with other bridges. See: - symfony/symfony#36148 (comment) - symfony/symfony#41308 (comment) Commits ------- 82f1f9c618 Make Mailgun Header compatible with other Bridges
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.