Bump Symfony 6 to PHP 8 #41282
Bump Symfony 6 to PHP 8 #41282
Conversation
|
Hey! But you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
|
Thank you @nicolas-grekas. |
|
Just a note: there is an issue with PHP 8.0.5 and Postgresql which is why 8.0.6 was released. |
|
For the record, 8.0.2 was chosen as the minimum because that's the version that runs on Travis. |
|
8.0.2 is a reasonable requirement. We can still fine tune this before November, but a Postgres compat issue is not enough to block 8.0.5 imho. |
|
I'm also fine with 8.0.2. Just wanted to note this in case someone is setting up a project with 8.0.5 and then gets errors (happened to me recently). |
|
Well, in any case, the recommended version is always the uptodate patch release, to benefit from PHP bugfixes. This constraint is about the minimum version, not the recommended one. |
| @@ -216,8 +216,6 @@ jobs: | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| echo "::group::fake PHP version" | ||
| composer config platform.php 8.0.99 |
This PR was merged into the 6.0 branch. Discussion ---------- Fake PHP version on PHP nightly builds | Q | A | ------------- | --- | Branch? | 6.0 | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A These two lines have been removed in #41282. Unfortunately, we still need them because people set upper boundaries in their composer.json. Without lying to composer, we cannot install dependencies on PHP 8.1 (yet). Commits ------- 6d6ea6d Fake PHP version on PHP nightly builds
馃帀