ping @symfony/mergers

@OskarStark Thanks for the review.

I added tests + entry in the CHANGELOG.
It should be OK

Thank you for this PR.

This scenario seams like an edge case. My experience is obviously biased, but I can count the number of times I've been working with DB transactions on my one hand.

Given you have code in your handler that open a transaction, I think that handler should also be responsible to make sure the transaction is closed.

I do see the value for a middleware like this in your application or in a third partly library. But I don't think it should be in the Symfony organisation.

Im 👎

Don't get me wrong: this middleware is a watchdog. People should not really on it. As you can see, when it's triggered, it generates an error log.

So yes, all open transaction must to closed in the handler, I agree with you on this point.

People tend to like this feature: https://twitter.com/lyrixx/status/1437440305159094275 and https://twitter.com/lyrixx/status/1418497608658661382

Another option would be to throw an exception when the transaction is not finished.

Another option would be to throw an exception when the transaction is not finished.

ping @Nyholm ; What do you think ? 👆

First sentence of the description says: "This is a WIP to get some feedback." So, I suppose it cannot be merged yet :)

@fabpot I have edited the PR description, thanks :)

I share Tobias's feeling here, the proposed middleware seems too specific for being in core to me (same for the exception alternative).

@chalasr as I explained in the PR description, forgetting to close a transaction can really hurt. IMHO this middleware should be native and not op-tin 😬

I understand your point of view, but as you can see, people on twitter tend to like it 👼🏼

Well, it's less than your average likes on contrib related tweets isn't it? 🙃

Jokes aside, I can see the potential value for debugging so I won't block this PR.
Could it just log? Or perhaps it could be configurable (log vs exception vs rollback)?

I could just log indeed, without exception, and without throwing. I'll update the PR.

I updated the PR. now, it only log at error level when a transaction is open

Maybe "Detect" is more appropriate than "watchdog"?

I have renamed everything:

Add a middleware to log when transaction has been left open DoctrineOpenTransactionLoggerMiddleware

Thank you @lyrixx.