[DependencyInjection] Inherit "public" option when creating aliases with the auto_alias tag #41209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,7 @@ public function process(ContainerBuilder $container) | ||
|
|
||
| $aliasId = $container->getParameterBag()->resolveValue($tag['format']); | ||
| if ($container->hasDefinition($aliasId) || $container->hasAlias($aliasId)) { | ||
| $container->setAlias($serviceId, new Alias($aliasId, true)); | ||
| $container->setAlias($serviceId, new Alias($aliasId, $container->getDefinition($serviceId)->isPublic())); |
There was a problem hiding this comment.
this should come with a BC layer that triggers a deprecation when the alias is used as a public one while the target is private
There was a problem hiding this comment.
@nicolas-grekas Done, if public is not explicitly set it will default to true and trigger a deprecation. In the future the deprecation can be removed and false set as the default.
There was a problem hiding this comment.
I was thinking about something like https://symfony.com/blog/new-in-symfony-5-1-deprecate-public-services-into-private-services but for aliases. Not sure how. /cc @fancyweb
|
Thanks for the PR. I decided to submit #42959 instead. Please have a look. |
|
@nicolas-grekas Great, thank you 😄 |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 10, 2021
…ault (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Make auto-aliases private by default | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | - | License | MIT | Doc PR | - Replaces #41209 Before, this creates a public autoalias: ```yaml app.lock: tags: - { name: auto_alias, format: "app.%database_type%_lock" } ``` After, this creates a public autoalias: ```yaml app.lock: public: true tags: - { name: auto_alias, format: "app.%database_type%_lock" } ``` Omitting `public: true` will trigger a deprecation warning when the alias is accessed from `$container->get()`. In 6.0, the alias will be private by default if `public: true` is not set. Commits ------- 679f25e [DependencyInjection] Make auto-aliases private by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using the
auto_aliastag, the aliases created are alwayspublic. With this PR the public option is inherited from the definition: