Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[DependencyInjection] Don't try to load YamlFileLoader if it's not actually needed #41170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #41169
License MIT
Doc PR -

This PR enables using DI without Config when autoconfiguration is not used.
(When autoconfiguration is used, the dependency on Config is still there.)

@nicolas-grekas nicolas-grekas added this to the 5.3 milestone May 11, 2021
@carsonbot carsonbot changed the title [DI] Don't try to load YamlFileLoader if it's not actually needed [DependencyInjection] Don't try to load YamlFileLoader if it's not actually needed May 11, 2021
@nicolas-grekas
Copy link
Member Author

(false positives from psalm)

@longwave
Copy link
Contributor

👍 this solves the dependency issue for Drupal

@derrabus
Copy link
Member

derrabus commented May 11, 2021

@nicolas-grekas The Travis failures look related.

@nicolas-grekas
Copy link
Member Author

Thanks for the ping @derrabus, should be fixed now.

@derrabus
Copy link
Member

Thank you @nicolas-grekas.

@derrabus derrabus merged commit 1bf384a into symfony:5.x May 11, 2021
@nicolas-grekas nicolas-grekas deleted the di-lazy branch May 12, 2021 07:25
@fabpot fabpot mentioned this pull request May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

symfony/dependency-injection has a hard dependency on symfony/config under PHP 8
5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.