Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[CI] Sort packages by length to match modified package better #40928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Apr 23, 2021

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Given the build error in #40927, I saw that we match "modified packages" wrong. The script things we modified symfony/translation rather than the new bridge. This is because we are using a simple string matchning. If we sort the packages by length, we make sure we match the most detailed (longest) string first.

.github/get-modified-packages.php Outdated Show resolved Hide resolved
@Nyholm
Copy link
Member Author

Nyholm commented Apr 27, 2021

PR is rebased and squashed

@OskarStark
Copy link
Contributor

Thanks Tobias.

@OskarStark OskarStark merged commit 63496df into symfony:5.x Apr 27, 2021
@Nyholm
Copy link
Member Author

Nyholm commented Apr 27, 2021

Lovely. Thank you for merging =)

@Nyholm Nyholm deleted the ci-package-sort branch April 27, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.