[PropertyInfo] fix attribute namespace with recursive traits #40874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soullivaneuh
commented
Apr 19, 2021
|
|
||
| try { |
There was a problem hiding this comment.
Note: I moved the login out the try/catch block because as far as I know, this statement is for the $this->docBlockFactory->create line below, not for the recursive resolution.
Please tell me if I'm wrong. 👍
nicolas-grekas
approved these changes
Apr 20, 2021
fabpot
reviewed
Apr 20, 2021
src/Symfony/Component/PropertyInfo/Tests/Fixtures/TraitUsage/DummyTrait.php
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Apr 21, 2021
1be04b8 to
bbadfb3
Compare
|
Thank you @soullivaneuh. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The targeted issue is closed because considered as solved by #40175.
However, the fix is not enough and is not working with recursive trait inclusion. (see #36997 (comment)).
This pull request is completing the first fix of @xabbuh, trying to follow the same coding style. 😉