Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[ErrorHandler] Avoid calling xdebug_get_function_stack() in xdebug >= 3.0 when not in develop mode #40787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[ErrorHandler] Avoid calling xdebug_get_function_stack() in xdebug >= 3.0 when not in develop mode #40787

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a319e4
Better fix for xdebug >= 3.0 when trying to produce a trace during Fa…
ralphschindler Apr 12, 2021
4c108bd
CS Fix
ralphschindler Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
CS Fix
  • Loading branch information
@ralphschindler
ralphschindler committed Apr 12, 2021
commit 4c108bd6a66ec44746aac38dfbf2eda0ef878aec
2 changes: 1 addition & 1 deletion 2 src/Symfony/Component/ErrorHandler/Error/FatalError.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public function __construct(string $message, int $code, array $error, int $trace
}
} elseif (null !== $traceOffset) {
// xdebug >= 3.0 has an ini xdebug.mode (not present in v2) that must be set to 'develop' for xdebug_get_function_stack()
if (\function_exists('xdebug_get_function_stack') && in_array(ini_get('xdebug.mode'), ['develop', false], true)) {
if (\function_exists('xdebug_get_function_stack') && \in_array(ini_get('xdebug.mode'), ['develop', false], true)) {
$trace = xdebug_get_function_stack();
if (0 < $traceOffset) {
array_splice($trace, -$traceOffset);
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.