Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[FORM] Add option grouping in TimezoneType #40757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[FORM] Add option grouping in TimezoneType #40757

wants to merge 4 commits into from

Conversation

arvodia
Copy link

@arvodia arvodia commented Apr 10, 2021

add in the options the grouping, which allows group according to the continents.

Q A
Branch? 5.x for features
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR symfony/symfony-docs#...

@arvodia
Update TimezoneType.php
dea4183 
add in the options the grouping, which allows group according to the continents.
@arvodia arvodia requested review from xabbuh and yceruto as code owners April 10, 2021 01:08
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@arvodia
Update TimezoneType.php
734c33a 
add grouping by continent for (getPhpTimezones and getIntlTimezones) 
to activate grouping, add the "grouping" parameters to true in the options
@ro0NL
Copy link
Contributor

ro0NL commented Apr 10, 2021

such grouping was intentionaly reverted in #31293, in favor of existing group_by. Im not sure we should introducing grouping now.

@arvodia arvodia changed the title Update TimezoneType.php [Form] Update TimezoneType.php Apr 10, 2021
@arvodia arvodia changed the title [Form] Update TimezoneType.php [FORM] Add option grouping in TimezoneType Apr 10, 2021
@arvodia
Copy link
Author

arvodia commented Apr 10, 2021

performance and display is better than "group_by"

@arvodia arvodia closed this Apr 10, 2021
@arvodia arvodia deleted the patch-1 branch April 10, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Feature Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arvodia @carsonbot @ro0NL
Morty Proxy This is a proxified and sanitized view of the page, visit original site.