Revert "[Command] fix emojis messing up the line width" #40697
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 36b36dc.
chalasr
approved these changes
Apr 3, 2021
|
This patch was a step in the right direction. Merging it on 5.x won't make it less a regression for the referenced issue, unless we also fix the issue with width vs length, which then would be a bugfix, thus on 5.2 too. :) What I mean is that I'm fine reverting, but the new patch would still be a fix, thus for 5.2 as of today. |
|
See this as an alternative approach: #40698 |
|
Closing in favor of #40698. |
|
Thank you |
fabpot
added a commit
that referenced
this pull request
Apr 8, 2021
…, grasmash) This PR was merged into the 5.2 branch. Discussion ---------- [Console] Add Helper::width() and Helper::length() | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Close #40697 Fix #40634, fix #40635 | License | MIT | Doc PR | This PR will add add a Helper::strwidth() and a Helper::strlength(). Same with with the Helper::strlenWithoutDecoration(). It does not deprecate anything. That is done in #40695 With this PR we dont have to revert the emoji issue (ie close #40697) FYI @grasmash, I used your tests from #40635 Commits ------- d9ea4c5 Add test. dc02ab3 [Console] Add Helper::strwidth() and Helper::strlength()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 36b36dc.
PR #40524 cause a few regressions. There is a confusion between string "length" and string "width". This is sorted out in #40695.
I suggest reapply this commit on 5.x instead.