[DependencyInjection] Implement psr/container 1.1 #40384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
psr/container
interfaces have been updated with type declarations. The lack of those is what kept us from adding property type declarations to theget()
andhas()
methods of our ownContainerInterface
.A small BC break is that we have never prevented calling code from passing
null
as the service ID. Even without strict types, this will cause aTypeError
after my changes. I already had to updateAutowirePass
because of that.On the other hand, it was neither documented that we allow
null
here nor did the container do anything useful (has(null)
always resulted infalse
andget(null)
always returnednull
).