Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[DependencyInjection] Implement psr/container 1.1 #40384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Mar 5, 2021

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

The psr/container interfaces have been updated with type declarations. The lack of those is what kept us from adding property type declarations to the get() and has() methods of our own ContainerInterface.

A small BC break is that we have never prevented calling code from passing null as the service ID. Even without strict types, this will cause a TypeError after my changes. I already had to update AutowirePass because of that.

On the other hand, it was neither documented that we allow null here nor did the container do anything useful (has(null) always resulted in false and get(null) always returned null).

@derrabus derrabus force-pushed the psr-container-1.1 branch 2 times, most recently from 027a378 to 3284c2b Compare March 5, 2021 20:18
@derrabus derrabus force-pushed the psr-container-1.1 branch from 3284c2b to d9095aa Compare March 5, 2021 22:52
@fabpot
Copy link
Member

fabpot commented Mar 6, 2021

Thank you @derrabus.

@fabpot fabpot merged commit 25e8d7d into symfony:5.x Mar 6, 2021
@derrabus derrabus deleted the psr-container-1.1 branch March 6, 2021 08:48
@fabpot fabpot mentioned this pull request Apr 18, 2021
@derrabus derrabus added this to the 5.3 milestone Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.